Skip to content

Fix vertex paint toolbar icon in packaged builds - #342

Merged
fernandotonon merged 1 commit into
masterfrom
fix/vertex-paint-brush-icon
Apr 29, 2026
Merged

Fix vertex paint toolbar icon in packaged builds#342
fernandotonon merged 1 commit into
masterfrom
fix/vertex-paint-brush-icon

Conversation

@fernandotonon

@fernandotonon fernandotonon commented Apr 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Fix vertex paint toolbar button showing an empty icon in installed/package builds.
  • Remove reliance on SVG icon rendering by painting a small green brush icon into a QPixmap.

Test plan

  • Build QtMeshEditor.
  • Enter Edit Mode, confirm the vertex paint button shows a brush icon.
  • Verify it still toggles paint mode and opens the settings menu.

Made with Cursor

Summary by CodeRabbit

  • Style
    • Updated the Vertex paint toolbar brush icon with a new design and increased display size from 16x16 to 18x18 pixels.

@fernandotonon
fix(ui): avoid SVG dependency for vertex paint icon
c30dffd 
Paint the vertex paint brush icon into a QPixmap so packaged builds that don't ship the Qt SVG icon plugin still render a consistent green brush in the toolbar.

Made-with: Cursor
@coderabbitai

coderabbitai Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 77648a77-1ae5-43b4-8b68-608147b14cf5

📥 Commits

Reviewing files that changed from the base of the PR and between 9e970b3 and c30dffd.

📒 Files selected for processing (1)
  • src/mainwindow.cpp
📝 Walkthrough

Walkthrough

The Vertex paint toolbar button icon is changed from an SVG resource to a procedurally generated brush icon created at runtime using QPainter, with display size updated from 16x16 to 18x18.

Changes

Cohort / File(s) Summary
Toolbar Icon Generation
src/mainwindow.cpp		 Replace paintbrush.svg resource with procedurally generated brush icon using QPainter into a transparent QPixmap; update icon display size from 16x16 to 18x18.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A brush is born from pixels bright,
No SVG needed in the night,
QPainter's magic, swift and true,
Eighteen-squared, a lovely view,
Our toolbar hops with colors new! 🎨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing the vertex paint toolbar icon appearance in packaged builds, which is the primary focus of the changeset.
Description check ✅ Passed The description covers the required template sections with a clear summary of the fix and a practical test plan, adequately addressing both the problem and its validation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vertex-paint-brush-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fernandotonon
fernandotonon merged commit 81890fa into master Apr 29, 2026
19 checks passed
@fernandotonon
fernandotonon deleted the fix/vertex-paint-brush-icon branch April 29, 2026 18:13
@fernandotonon fernandotonon linked an issue Apr 29, 2026 that may be closed by this pull request
Paint: Vertex Paint UI in Inspector (QML) #315
Closed
@fernandotonon fernandotonon mentioned this pull request Apr 29, 2026
Merged
10 tasks
@coderabbitai coderabbitai Bot mentioned this pull request May 15, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Paint: Vertex Paint UI in Inspector (QML)

1 participant

@fernandotonon